thanx

Thanks for a terrific theme, I just want to bring something to your attention…

If you’re monitoring your PHP error logs, you’ll see that your filter code snippet throws 2 exceptions:

[8: Notice] Undefined index: link_before [...]\wp-includes\post-template.php Line: 845 and
[8: Notice] Undefined index: link_after [...]\wp-includes\post-template.php Line: 845

This is because the filter completely replaces the original $args array. Two ways to deal with this…

1) Quick n Dirty: append this to the child’s $args array –

,'link_before'=>'','link_after'=>''

The empty strings are WordPress’ defaults, and may or may not match the actual runtime values (and you might not care, but you should).

2) Probably more ‘proper’ and likely more future-proof is to merge our options into the inbound array using the WP core’s wp_parse_args(), thus:


function childtheme_menu_args( $args ) {
$my_args = array(
'show_home' => 'Home',
'sort_column' => 'menu_order',
'menu_class' => 'menu',
'echo' => false
);
return wp_parse_args( $my_args, $args );
}
add_filter('wp_page_menu_args','childtheme_menu_args', 20);


which works for me, running PHP 5.2.6 + WP 3.0.2 + Thematic .9.7.7.

And yes, the parameter order for wp_parse_args() is indeed counter-intuitive.

HTH

Thanks for the new version of Thematic. Just installed it and it broke the menu on my child theme, but I was able to find the solution in this blog post. I had filtered out some of the pages and when I upgraded, my code in functions.php was no longer filtering out some links.

Thanks again!

have a look at the priority 20 !!!

Hope this info is helpfull.